Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(pipes-targets): add API Gateway #31954

Merged
merged 14 commits into from
Nov 26, 2024
Merged

feat(pipes-targets): add API Gateway #31954

merged 14 commits into from
Nov 26, 2024

Conversation

msambol
Copy link
Contributor

@msambol msambol commented Oct 30, 2024 •
edited
Loading

Add API Gateway REST API as a Pipes target.

Original PR with community review from @nmussy: #30772

@aws-cdk-automation aws-cdk-automation requested a review from a team October 30, 2024 22:54
@github-actions github-actions bot added distinguished-contributor [Pilot] contributed 50+ PRs to the CDK p2 labels Oct 30, 2024
@aws-cdk-automation aws-cdk-automation added the pr/needs-community-review This PR needs a review from a Trusted Community Member or Core Team Member. label Oct 30, 2024
@msambol
Copy link
Contributor Author

msambol commented Oct 30, 2024 •
edited
Loading

@Leo10Gama Got another one for you :) This was first reviewed in #30772, but was closed because of inactivity/merge conflicts.

@github-actions github-actions bot mentioned this pull request Nov 1, 2024
Closed
@msambol msambol force-pushed the pipes-targets-api-gw branch from 5249ea2 to db15170 Compare November 2, 2024 00:36
@msambol msambol force-pushed the pipes-targets-api-gw branch from db15170 to 4709a1c Compare November 2, 2024 00:38
@github-actions github-actions bot mentioned this pull request Nov 4, 2024
Closed
@Leo10Gama Leo10Gama self-assigned this Nov 6, 2024
Leo10Gama
Leo10Gama reviewed Nov 6, 2024
View reviewed changes
Copy link
Member

@Leo10Gama Leo10Gama left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks pretty good! Because of some of the policy permissions, I'm adding in the needs-security-review label as well, and review with security to verify the changes are OK. Other than that, one comment about how we're verifying the integ test.

packages/@aws-cdk/aws-pipes-targets-alpha/test/integ.api-gateway.ts Show resolved Hide resolved
@Leo10Gama Leo10Gama added the needs-security-review Related to feature or issues that needs security review label Nov 6, 2024
@Leo10Gama Leo10Gama removed the needs-security-review Related to feature or issues that needs security review label Nov 22, 2024
Leo10Gama
Leo10Gama previously approved these changes Nov 22, 2024
View reviewed changes
Copy link
Member

@Leo10Gama Leo10Gama left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good, thanks again for the contribution!

@Leo10Gama
Copy link
Member

@Mergifyio update

@mergify Mergify
Copy link
Contributor

mergify bot commented Nov 22, 2024

update

❌ Mergify doesn't have permission to update

For security reasons, Mergify can't update this pull request. Try updating locally.
GitHub response: refusing to allow a GitHub App to create or update workflow .github/workflows/codecov.yml without workflows permission

@mergify Mergify
Copy link
Contributor

mergify bot commented Nov 22, 2024

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@aws-cdk-automation aws-cdk-automation removed the pr/needs-community-review This PR needs a review from a Trusted Community Member or Core Team Member. label Nov 22, 2024
@mergify Mergify
Copy link
Contributor

mergify bot commented Nov 22, 2024

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mergify mergify bot dismissed Leo10Gama’s stale review November 22, 2024 19:46

Pull request has been modified.

@aws-cdk-automation aws-cdk-automation added the pr/needs-community-review This PR needs a review from a Trusted Community Member or Core Team Member. label Nov 22, 2024
@msambol
Copy link
Contributor Author

msambol commented Nov 22, 2024

@Leo10Gama mind re-approving this one? looks like the merge dismissed your review.

@codecov Codecov
Copy link

codecov bot commented Nov 25, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 77.46%. Comparing base (c789063) to head (7c6a89b).
Report is 1 commits behind head on main.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main   #31954   +/-   ##
=======================================
  Coverage   77.46%   77.46%           
=======================================
  Files         105      105           
  Lines        7168     7168           
  Branches     1314     1314           
=======================================
  Hits         5553     5553           
  Misses       1433     1433           
  Partials      182      182
Flag Coverage Δ
suite.unit 77.46% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
packages/aws-cdk 77.46% <ø> (ø)

@mergify Mergify
Copy link
Contributor

mergify bot commented Nov 25, 2024

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@aws-cdk-automation aws-cdk-automation removed the pr/needs-community-review This PR needs a review from a Trusted Community Member or Core Team Member. label Nov 25, 2024
@mergify Mergify
Copy link
Contributor

mergify bot commented Nov 25, 2024

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
  • Commit ID: 7c6a89b
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify mergify bot merged commit c77536f into aws:main Nov 26, 2024
17 checks passed
@mergify Mergify
Copy link
Contributor

mergify bot commented Nov 26, 2024

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@github-actions GitHub Actions
Copy link

Comments on closed issues and PRs are hard for our team to see.
If you need help, please open a new issue that references this one.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 26, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@Leo10Gama Leo10Gama Leo10Gama approved these changes

Assignees

@Leo10Gama Leo10Gama

Labels
distinguished-contributor [Pilot] contributed 50+ PRs to the CDK p2
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@msambol @Leo10Gama @aws-cdk-automation